Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for client connection hooks should warn against wrapping errors #1101

Closed
rolandshoemaker opened this issue Mar 2, 2017 · 0 comments · Fixed by #1125
Closed

Comments

@rolandshoemaker
Copy link
Contributor

Documentation for the various interface methods that can be hook into the client connection process (i.e. TransportCredentials.ClientHandshake etc) should warn that errors returned from these methods should not be wrapped with an error type that doesn't expose a Temporary method. Doing this can cause relatively hard to debug reconnect behavior.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant