Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add document to ClientHandshake about returning temporary error #1125

Merged
merged 1 commit into from
Mar 28, 2017
Merged

add document to ClientHandshake about returning temporary error #1125

merged 1 commit into from
Mar 28, 2017

Conversation

menghanl
Copy link
Contributor

fixes #1101

@dfawley
Copy link
Member

dfawley commented Mar 28, 2017

LGTM

@menghanl menghanl merged commit ccdf270 into grpc:master Mar 28, 2017
@menghanl menghanl added the 1.3 label Mar 28, 2017
@menghanl menghanl deleted the ClientHandshake_error_doc branch March 28, 2017 18:13
@menghanl menghanl added the Type: Documentation Documentation or examples label Apr 22, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for client connection hooks should warn against wrapping errors
2 participants
@menghanl @dfawley