Don't return an error from dial if the balancer returns no initial servers #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvers This modifies the WithBlock behavior somewhat to block until there is at least one valid connection. Previously, each connection would be made serially until all had completed successfully, with any errors returned to the caller. Errors are now only returned due to connecting to a backend if a balancer is not used, or if there is an error starting the balancer itself. Fixes grpc#976
MakMukhi
reviewed
Mar 14, 2017
| if ch != nil { | ||
| if cc.dopts.block { | ||
| doneChan := make(chan struct{}) | ||
| go cc.lbWatcher(doneChan) |
There was a problem hiding this comment.
In blocking mode, we need a mechanism for lbwatcher to send an error back(if there's one) to DialContext so that the users can be intimated about it.
Also, we need to discuss which error should lbwatcher return since there could be multiple errors while connecting to multiple servers
menghanl
added
Type: Behavior Change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also modifies the WithBlock behavior somewhat to block until there is at least one
valid connection. Previously, each connection would be made serially until all
had completed successfully, with any errors returned to the caller. Errors are
now only returned due to connecting to a backend if a balancer is not used, or
if there is an error starting the balancer itself.
Fixes #976