Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grpc.Version string and use it in the UA #1144

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Add grpc.Version string and use it in the UA #1144

merged 1 commit into from
Mar 24, 2017

Conversation

menghanl
Copy link
Contributor

fixes #1081

dfawley
dfawley reviewed Mar 24, 2017
View reviewed changes
transport/http2_client.go Outdated
if opts.UserAgent != "" {
ua = opts.UserAgent + " " + ua
}
ua := opts.UserAgent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this local and use opts.UserAgent below directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dfawley
Copy link
Member

dfawley commented Mar 24, 2017

LGTM

@menghanl menghanl merged commit 14a6be4 into grpc:master Mar 24, 2017
@menghanl menghanl deleted the ua_version branch March 24, 2017 18:29
menghanl added a commit that referenced this pull request Apr 7, 2017
@menghanl
Add grpc.Version string and use it in the UA (#1144)
9aa08c5
@menghanl menghanl added Type: Feature New features or improvements in behavior and removed Release Notes labels Apr 22, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley left review comments

Assignees
No one assigned
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide grpc version constant
2 participants
@menghanl @dfawley