Change status package to deal with concrete types instead of interfaces #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
Apr 6, 2017
status/status.go
Outdated
| if s.Code() == codes.OK { | ||
| return nil | ||
| } | ||
| return (*statusError)(proto.Clone(s.s).(*spb.Status)) |
There was a problem hiding this comment.
Why do we still make a clone here?
There was a problem hiding this comment.
To make it impossible to mutate the statusError and change the Code into OK.
Without this, but the rest of the code as-is, one could do:
status := status.New(codes.Internal, "blah")
p := status.Proto()
err := status.Err()
p.Code = int32(codes.OK)
Maybe status.Proto() and FromProto() should do the clone instead, making Status immutable, which is how I had it initially.
transport/transport.go
Outdated
| @@ -335,7 +335,7 @@ func (s *Stream) Read(p []byte) (n int, err error) { | |||
|
|
|||
| // finish sets the stream's state and status, and closes the done channel. | |||
| // s.mu must be held by the caller. | |||
| func (s *Stream) finish(st status.Status) { | |||
| func (s *Stream) finish(st *status.Status) { | |||
There was a problem hiding this comment.
Comment this should never be called with nil?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.