deduplicate dns record in lookup #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
Aug 22, 2017
naming/dns_resolver.go
Outdated
| } | ||
| return res | ||
|
|
naming/dns_resolver.go
Outdated
| delete(update, *u) | ||
| continue | ||
| func (w *dnsWatcher) compileUpdate(newAddrs map[string]*Update) []*Update { | ||
| res := make([]*Update, 0, len(newAddrs)+len(w.curAddrs)) |
There was a problem hiding this comment.
How about just var res []*Update?
Length of updates may be much shorter than len(newAddrs)+len(w.curAddrs).
naming/dns_resolver.go
Outdated
| @@ -231,15 +228,15 @@ func (w *dnsWatcher) lookupSRV() []*Update { | |||
| grpclog.Errorf("grpc: failed IP parsing due to %v.\n", err) | |||
| continue | |||
| } | |||
| newAddrs = append(newAddrs, &Update{Addr: a + ":" + strconv.Itoa(int(s.Port)), | |||
| Metadata: AddrMetadataGRPCLB{AddrType: GRPCLB, ServerName: s.Target}}) | |||
| newAddrs[a+":"+strconv.Itoa(int(s.Port))] = &Update{Addr: a + ":" + strconv.Itoa(int(s.Port)), | |||
There was a problem hiding this comment.
Add a local variable for a+":"+strconv.Itoa(int(s.Port))?
naming/dns_resolver.go
Outdated
| @@ -251,7 +248,7 @@ func (w *dnsWatcher) lookupHost() []*Update { | |||
| grpclog.Errorf("grpc: failed IP parsing due to %v.\n", err) | |||
| continue | |||
| } | |||
| newAddrs = append(newAddrs, &Update{Addr: a + ":" + w.port}) | |||
| newAddrs[a+":"+w.port] = &Update{Addr: a + ":" + w.port} | |||
There was a problem hiding this comment.
Local variable for a+":"+w.port?
menghanl
pushed a commit
to menghanl/grpc-go
that referenced
this pull request
Aug 30, 2017
deduplicate dns record in lookup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.