Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update deps #7282

Merged
merged 10 commits into from
May 31, 2024
Merged

*: update deps #7282

merged 10 commits into from
May 31, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented May 30, 2024

I got the feeling that #7274 was not complete. For that PR, I ran go mod tidy with --compat=1.19 to update the deps per our release manual. However, toolchain declarative got added pointing to go1.22.1. I think this is based on the go env on my local.

Taking into we have already drop support for 1.19 and 1.20, I updated all references to older go versions from the repo including:

  1. go.mod s
  2. staticheck in vet.sh
  3. go mod tidy in vet.sh

This PR contains the changes that includes everything i said above plus, the additional changes that were required to remove deprecated usages of

  1. rand.Seed
  2. RevocationList.RevokedCertificates

RELEASE NOTES: none

@arvindbr8 arvindbr8 added the Type: Meta Github repo, process, etc label May 30, 2024
@arvindbr8 arvindbr8 added this to the 1.65 Release milestone May 30, 2024
@arvindbr8 arvindbr8 requested a review from dfawley May 30, 2024 01:44
cmd/protoc-gen-go-grpc/go.mod Show resolved Hide resolved
@@ -1,6 +1,6 @@
module google.golang.org/grpc

go 1.19
go 1.21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar question here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have a question about this, I don't think you use any feature of the language that isn't in 1.19, and that change then propagates to my library which, while I personally build binary with 1.22.5, I'd rather not force upgrade yet for users (and I was planning on a minor patch level bump but if my go.mod changes from 1.19 to 1.21 I'd have to make a new minor)

Copy link

@ldemailly ldemailly Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm

stats/opentelemetry module pulls in dependency which requires go1.21+

so I guess I would need to track down why they bumped it... possibly unnecessarily or just "because 1.19 is not supported anymore" which imo isn't a valid reason, this is about language features

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the new normal for the Go ecosystem, particularly after the changes made to go.mod in 1.21. We won't bump this unless we have to, but it will become more and more likely that we'll need to shortly after any new Go version is released.

@dfawley dfawley assigned arvindbr8 and unassigned dfawley May 30, 2024
@arvindbr8
Copy link
Member Author

Per offline discussion yday:

There seems to be enough reasons for gRPC-Go to require go1.21, but is not limited to:"

  1. To remove grpcrand and use math/rand directly
  2. stats/opentelemetry module pulls in dependency which requires go1.21+

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 May 31, 2024
@arvindbr8 arvindbr8 requested a review from dfawley May 31, 2024 20:08
@dfawley dfawley assigned arvindbr8 and unassigned dfawley May 31, 2024
@arvindbr8 arvindbr8 merged commit 32f6091 into grpc:master May 31, 2024
11 checks passed
@caldempsey
Copy link

Opinion piece: I think one of the best things about Go is the communities cadence to not sit on old versions of Golang. It is inconvenient to force an upgrade, yes, but we also have to learn from history. We also have to learn from TypeScript. The principle of least pain suggests to me that staying current is a greater wisdom than falling so far behind developers have to be juggling four versions of Node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Meta Github repo, process, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants