Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: use locality from the connected address for load reporting #7378

Merged
merged 9 commits into from
Jul 10, 2024

Address review comments (5/x).

64ae662
Select commit
Loading
Failed to load commit list.
Merged

xds: use locality from the connected address for load reporting #7378

Address review comments (5/x).
64ae662
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 10, 2024 in 0s

81.34% (-0.13%) compared to c9caa9e

View this Pull Request on Codecov

81.34% (-0.13%) compared to c9caa9e

Details

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (c9caa9e) to head (64ae662).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7378      +/-   ##
==========================================
- Coverage   81.47%   81.34%   -0.13%     
==========================================
  Files         348      348              
  Lines       26753    26757       +4     
==========================================
- Hits        21796    21765      -31     
- Misses       3769     3795      +26     
- Partials     1188     1197       +9     
Files Coverage Δ
balancer/balancer.go 95.45% <100.00%> (+1.70%) ⬆️
balancer_wrapper.go 88.74% <100.00%> (+2.25%) ⬆️
clientconn.go 93.34% <100.00%> (+0.19%) ⬆️
xds/internal/internal.go 73.91% <100.00%> (+2.48%) ⬆️
xds/internal/balancer/clusterimpl/clusterimpl.go 86.40% <85.71%> (-1.33%) ⬇️

... and 28 files with indirect coverage changes