Correct bogus stack-trace information after AST traversal (fixes #2) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We splice in AST data generated by ast.parse()ing a text block. This AST carries its own metadata (lineno and friends) associated with the injected code. When it's introspected in the process of generating a traceback, it's bogus because it doesn't correspond to lines of code in the actual ipython cell. This patch introduces a second AST transformer that recursively copies node metadata from the original, un-transformed AST. As a result, traceback can point to the correct line of original code (even if it's not what actually got executed.)
gsmecher
force-pushed
the
fix_stacktraces
branch
from
c07114f
to
d12bb21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We splice in AST data generated by ast.parse()ing a text block. This AST carries its own metadata (lineno and friends) associated with the injected code. When it's introspected in the process of generating a traceback, it's bogus because it doesn't correspond to lines of code in the actual ipython cell.
This PR introduces a second AST transformer that recursively copies node metadata from the original, un-transformed AST. As a result, traceback can point to the correct line of original code (even if it's not what actually got executed.)