Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing project_id issue #19

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fixed missing project_id issue #19

merged 1 commit into from
Mar 14, 2022

Conversation

sanak
Copy link
Member

@sanak sanak commented Mar 13, 2022

Fixes #4.

Changes proposed in this pull request:

  • Add text_block_project_id as hidden input tag when to support available project is only one case.

@gtt-project/maintainer

@sanak
Copy link
Member Author

sanak commented Mar 14, 2022

@dkastl Thanks for approving this!
I will merge this now. (CC: @mopinfish)

@sanak sanak merged commit 43e4724 into main Mar 14, 2022
@mopinfish
Copy link

@sanak I've checked this changes. LGTM.

@sanak
Copy link
Member Author

sanak commented Mar 15, 2022

@mopinfish Okay, thanks!

@@ -35,9 +35,16 @@ var TextBlocks = {
},

reload: function(e){
debugger
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkastl @mopinfish
Sorry, I forgot to delete this line...
I will delete this line on main branch directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it seems to impossible to push main branch directly, so I will make PR to delete this line...

@dkastl dkastl deleted the fix/undefined-project-id branch September 6, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[BUG] ActiveRecord::RecordNotFound (Couldn't find Project with identifier=undefined):
3 participants