add a manylinux image for building X86_64 wheels #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
changed the title
jameslamb
commented
Nov 9, 2022
| @@ -0,0 +1,93 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This file was exactly copied from https://github.com/guolinke/lightgbm-ci-docker/blob/master/dockers/ubuntu-14.04/start_azure.sh. I didn't change anything ini it.
60 tasks
jameslamb
changed the title
guolinke
approved these changes
Nov 20, 2022
|
Is this ready to merge? |
|
Thanks @guolinke ! I believe it's ready to merge, yes. I've been testing it on microsoft/LightGBM#5580 all jobs are successful there. Ideally I'd like @StrikerRUS 's opinion but I know he hasn't been able to spend much time on open source recently. I think we should merge this. |
guolinke
pushed a commit
that referenced
this pull request
Nov 21, 2022
* Update publish_image.yml * Create Dockerfile * Update Dockerfile * Update Dockerfile * Update publish_image.yml * Update Dockerfile * Update Dockerfile * [ci] update docker action versions * add a manylinux image for building X86_64 wheels (#27) * Trigger workflow for `dev2` branch * have GitHub Actions try building clang from source * comment out unnecessary jobs * minimize clang build * actually install after building * add gcc RPATH to clang * use clang11, build libc++ * add PoCL and Java * fix trailing slash * add remaining components and clean up * fix JAVA_HOME * java-devel * install sudo * set JAVA_HOME to a location with jni.h * save clang to figure out what is happening * switch to symlinks for libc++ * uncomment * add /usr/local/lib64 to LD_LIBRARY_PATH Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * differentiate between builds in CI job names Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on microsoft/LightGBM#5514.
How I tested this
Ran the following, with environment variables based on https://github.com/microsoft/LightGBM/blob/master/.vsts-ci.yml.
For different combinations of
COMPILERandTASK.docker run \ --rm \ --pull always \ --entrypoint="" \ --env AZURE='true' \ --env BUILD_DIRECTORY=/usr/local/src/LightGBM \ --env COMPILER=gcc \ --env CONDA_ENV=test-env \ --env DOTNET_CLI_TELEMETRY_OPTOUT='true' \ --env DOTNET_SKIP_FIRST_TIME_EXPERIENCE='true' \ --env OS_NAME=linux \ --env PRODUCES_ARTIFACTS='true' \ --env PYTHON_VERSION='3.10' \ --env SETUP_CONDA='false' \ --env TASK=bdist \ --workdir /usr/local/src \ -it lightgbm/vsts-agent:manylinux_2_28_x86_64-dev2 \ bash -c 'export PATH="/opt/miniforge/bin:${PATH}"; git clone --recursive https://github.com/microsoft/LightGBM.git --branch ci/build-manylinux-x86_64-wheels && cd ./LightGBM && ./.ci/setup.sh && ./.ci/test.sh'