Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #2113

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Update index.html #2113

merged 2 commits into from
Feb 14, 2019

Conversation

mattbrundage
Copy link
Contributor

@mattbrundage mattbrundage commented Feb 13, 2019

A more succinct way of writing the conditional comment -- still recognized by IE 5-9.

IE10+ doesn't support conditional comments, however, IE10 would still benefit from the "outdated browser" message, as we recently dropped support.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A more succinct way of writing the conditional comment -- still recognized by IE 5-9. (IE10+ doesn't support conditional comments)
@coliff
Copy link
Member

coliff commented Feb 13, 2019

Agreed this is a good change to save a couple of bytes... the way it works though is exactly the same since IE10 ignores conditional statements.
REF: https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/ms537512(v=vs.85)

Copy link
Member

@coliff coliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also make this change in the 'dist' dir.

@mattbrundage
Copy link
Contributor Author

@coliff , I've made the change you requested.

Copy link
Member

@roblarsen roblarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@coliff coliff merged commit b91f2a9 into h5bp:master Feb 14, 2019
@mattbrundage mattbrundage deleted the patch-1 branch February 14, 2019 03:45
@coliff coliff mentioned this pull request Mar 7, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants