Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The remove command is set to the default behavior. #273

Closed
3 tasks done
Tracked by #274
, #277
...
hakancelikdev opened this issue Dec 12, 2022 · 2 comments · Fixed by #276
Closed
3 tasks done
Tracked by #274
, #277
...

The remove command is set to the default behavior. #273

hakancelikdev opened this issue Dec 12, 2022 · 2 comments · Fixed by #276
Assignees
@hakancelikdev
Labels
changelog Changes should be written to the changelog file. documentation Improvements or additions to documentation enhancement New feature or request test
Milestone
0.13.0

Comments

@hakancelikdev
Copy link
Owner

hakancelikdev commented Dec 12, 2022 •
edited
Loading

When addressing this issue, we must ensure that we consider the following situations:

  • Unimport should remove unnecessary imports by default (current behavior, --check, now it should be --remove)
  • Delete --remove related code, tests, and documentation.
  • The default behavior of unimport should be documented.

#270
@hakancelikdev hakancelikdev added documentation Improvements or additions to documentation enhancement New feature or request changelog Changes should be written to the changelog file. test labels Dec 12, 2022
@hakancelikdev hakancelikdev added this to the 0.13.0 milestone Dec 12, 2022
@hakancelikdev
Copy link
Owner Author

@mxr Here is the issue, If you have any questions, feel free to ask.

@hakancelikdev hakancelikdev mentioned this issue Dec 12, 2022
Closed
2 tasks
hakancelikdev added a commit that referenced this issue Jan 24, 2023
@hakancelikdev
feat: #273 remove flag set as current behavior
6c55300
@hakancelikdev hakancelikdev self-assigned this Jan 31, 2023
hakancelikdev added a commit that referenced this issue Jan 31, 2023
@hakancelikdev
feat: #273 remove flag set as current behavior
17c7cd1
@hakancelikdev hakancelikdev linked a pull request Jan 31, 2023 that will close this issue
feat: The remove command is set to the default behavior. #276
Merged
hakancelikdev added a commit that referenced this issue Jan 31, 2023
@hakancelikdev
feat: #273 remove flag set as current behavior
b438444
@hakancelikdev hakancelikdev mentioned this issue Feb 1, 2023
Merged
2 tasks
@mxr
Copy link
Contributor

mxr commented Feb 3, 2023

Thanks for solving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hakancelikdev hakancelikdev

Labels
changelog Changes should be written to the changelog file. documentation Improvements or additions to documentation enhancement New feature or request test
Projects
unimport's backlog
Status: ✅ Done
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

feat: The remove command is set to the default behavior. hakancelikdev/unimport
2 participants
@mxr @hakancelikdev