Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node 20 in all the build/test workflows #1435

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jul 18, 2024

Context

  • use node 20 in all the workflows
  • mention node 20 as the recommended version for HyperFormula developers in the docs

How did you test your changes?

  • run all the workflows in the GH environment

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Run all build scripts in Node Active LTS (currently 20) #1428

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Jul 18, 2024
@sequba sequba linked an issue Jul 18, 2024 that may be closed by this pull request
@sequba sequba merged commit f082027 into develop Jul 18, 2024
15 of 22 checks passed
@sequba sequba deleted the feature/issue-1428 branch July 18, 2024 15:21
Copy link

github-actions bot commented Jul 18, 2024

Performance comparison of head (0361c4e) vs base (df4ddc9)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 515.98 | 504.27 | -2.27%
                                      Sheet B | 165.91 | 166.78 | +0.52%
                                      Sheet T |  149.5 |  144.6 | -3.28%
                                Column ranges | 516.98 | 509.26 | -1.49%
Sheet A:  change value, add/remove row/column |  14.22 |  13.39 | -5.84%
 Sheet B: change value, add/remove row/column | 130.12 | 127.64 | -1.91%
                   Column ranges - add column | 152.33 | 152.99 | +0.43%
                Column ranges - without batch | 470.94 | 438.94 | -6.79%
                        Column ranges - batch | 113.12 | 112.13 | -0.88%

sequba added a commit that referenced this pull request Sep 4, 2024
* Use Node 20 in all the build/test workflows (#1435)

* Update build badge in readme to show the build workflow status instead of test (#1443)

* Update build badge to show the build workflow status instead of test

* Add build-docs workflow (#1434)

* Add build-docs workflow

* Add environment variables necessary to build the docs with Node 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run all build scripts in Node Active LTS (currently 20)
1 participant