Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stop using node0 at the first node name #538

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Sep 3, 2024

Description

This pull request changes the following:

  • Changing all unit test and e2e test to use node1 as the first node name

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Unit Test Results - Linux

  1 files   19 suites   49s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
149 runs  149 ✅ 0 💤 0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node PEM Stop Tests Coverage Report

13 tests   13 ✅  2m 31s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Relay Tests Coverage Report

1 files  1 suites   2m 28s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Tests Coverage Report

57 tests   57 ✅  3m 22s ⏱️
 9 suites   0 💤
 1 files     0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node PFX Kill Tests Coverage Report

13 tests   13 ✅  3m 5s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node Update Tests Coverage Report

12 tests   12 ✅  5m 6s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node Local Build Tests Coverage Report

10 tests   10 ✅  2m 55s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node Delete Tests Coverage Report

10 tests   10 ✅  5m 33s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Mirror Node Tests Coverage Report

 1 files   1 suites   3m 28s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
14 runs  14 ✅ 0 💤 0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node Add Tests Coverage Report

22 tests   22 ✅  14m 20s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

@JeffreyDallas JeffreyDallas changed the title cI: stop using node0 at the first node name ci: stop using node0 at the first node name Sep 3, 2024
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Unit Test Results - Windows

  1 files   19 suites   1m 35s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
149 runs  149 ✅ 0 💤 0 ❌

Results for commit 93fb4de.

♻️ This comment has been updated with latest results.

# Conflicts:
#	test/e2e/core/platform_installer_e2e.test.mjs
#	test/unit/core/platform_installer.test.mjs
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link

codacy-production bot commented Sep 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 4bb352b1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4bb352b) Report Missing Report Missing Report Missing
Head commit (93fb4de) 4142 3066 74.02%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#538) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.48%. Comparing base (c81c76a) to head (93fb4de).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
+ Coverage   81.66%   83.48%   +1.82%     
==========================================
  Files          35       36       +1     
  Lines        4429     4942     +513     
  Branches      671      700      +29     
==========================================
+ Hits         3617     4126     +509     
- Misses        812      816       +4     
Files with missing lines Coverage Δ
src/commands/prompts.mjs 69.48% <ø> (ø)
src/core/templates.mjs 73.17% <ø> (-3.76%) ⬇️
test/e2e/e2e_node_util.js 88.04% <100.00%> (ø)

... and 6 files with indirect coverage changes

Impacted file tree graph

Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
JeffreyDallas and others added 2 commits September 5, 2024 09:22
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
@JeffreyDallas JeffreyDallas merged commit 93dd38e into main Sep 5, 2024
41 checks passed
@JeffreyDallas JeffreyDallas deleted the 00525-D-node-rename branch September 5, 2024 17:34
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start at node1 alias instead of node0 for all test cases to align with platform constraint
3 participants