Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Bump go-azure-helpers to 0.7.0 #22524

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

radeksimko
Copy link
Member

This is to resolve the conundrum around broken dependency UX in downstream, as described in #22490

Closes #22490


This PR brings in updated go-azure-helpers with latest go-autorest which contains the fixes that were merged into the Azure SDK lately to address the problem.

Azure/go-autorest#414
Azure/go-autorest#455

cc @vancluever
cc @appilon

This allows providers upgrade to the latest Terraform SDK without confusing error messages, provided that they upgrade dependencies in the right order, where applicable - e.g. template provider may need to be upgraded first, if a provider depends on it.

@radeksimko radeksimko added the dependencies Auto-pinning label Aug 20, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@radeksimko radeksimko merged commit e68fe72 into master Aug 20, 2019
@radeksimko radeksimko deleted the vendor-bump-azure-deps branch August 20, 2019 09:26
@tamalsaha
Copy link

Thanks!

radeksimko added a commit that referenced this pull request Aug 20, 2019
This is to allow Terraform providers to upgrade to at least
one more minor version of the plugin SDK without major UX hiccups.

This concludes (unsuccessful) experiments involving upgrades
to SDK with Azure/go-autorest#455

Even with that patch all providers still experience broken UX
as described in #22490

This downgrade reduces the uncomfort to only a handful of providers
from >100s. The affected providers more or less directly depend on
Azure SDK(s), which is ~8.

Affected providers practically cannot consume Terraform Plugin SDK
with this patch (downgraded Azure SDKs) and can just wait for
extracted Terraform Plugin SDK which is planned to be released soon.

This reverts the following PRs:

 - #22247
 - #22248
 - #22524
 - #22525

and it is otherwise result of the following commands

```
go get github.com/Azure/azure-sdk-for-go@v21.3.0
go get github.com/hashicorp/go-azure-helpers@166dfd221bb2
go mod tidy
```
@ghost
Copy link

ghost commented Sep 20, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants