Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nil config when getting credentials #35

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Check for nil config when getting credentials #35

merged 2 commits into from
Apr 30, 2019

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Apr 23, 2019 •
edited
Loading

Fixes #34

parse_bindings are just some go test fixes.

@emilymye
Copy link
Contributor Author

cc/ @sethvargo since I can't request a review from you

@emilymye emilymye requested a review from jefferai April 23, 2019 18:54
@emilymye
Copy link
Contributor Author

@kalafut @jefferai I don't have merge access so I assume one of you will merge this in before next release? Thank you!

@kalafut kalafut merged commit b209b94 into hashicorp:master Apr 30, 2019
@kalafut
Copy link
Contributor

kalafut commented Apr 30, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalafut kalafut kalafut approved these changes

@sethvargo sethvargo sethvargo approved these changes

@jefferai jefferai Awaiting requested review from jefferai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic: Runtime Error after Upgrade to Vault 1.1.1
3 participants
@emilymye @kalafut @sethvargo