allow null types in batch encryption [VAULT-849] #10386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
reviewed
Nov 23, 2020
| @@ -154,39 +155,49 @@ func decodeBatchRequestItems(src interface{}, dst *[]BatchRequestItem) error { | |||
| } | |||
|
|
|||
| if v, has := item["context"]; has { | |||
| if casted, ok := v.(string); ok { | |||
| val := reflect.ValueOf(v) | |||
There was a problem hiding this comment.
Nit: We may not need val. How about if !reflect.ValueOf(v).IsValid()?
There was a problem hiding this comment.
Sounds good! Thank you for the review!
vishalnayak
approved these changes
Nov 23, 2020
|
I updated the PR to not allow plaintext to be "null". Everything else can have a "null" string as a value, as they are optional parameters in different situations. I let the ciphertext field be "null" as well, even though it shouldn't be necessary, because this value is not set by a vault user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow null values in the encryption payload, so as to be backward compatible with 1.4 functionality.