Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for #10416 #10473

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Add changelog for #10416 #10473

merged 3 commits into from
Dec 1, 2020

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Dec 1, 2020

I forgot to add this along with the original PR and it seems worthy of a changelog entry to me.

I've also added a readme pointing to the go-changelog tool for documentation.

I forgot to add this along with the original PR and it seems worthy of a changelog entry to me.
Copy link
Contributor

@mladlow mladlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - agree that a changelog is good. Thanks also for adding the readme.

#10416 doesn't have a milestone - if it needs to be backported to 1.6 the changelog entry will need to ride along (either another backport or combined in the backport PR) so it shows up in the 1.6.x changelog.

@@ -0,0 +1,3 @@
# changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@tomhjp tomhjp merged commit 83f5914 into master Dec 1, 2020
@tomhjp tomhjp deleted the sanitize-private-key branch December 1, 2020 16:08
tomhjp added a commit that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants