PostgreSQL - Add username customization #10766
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/bp51xa2n2 [Deployment for 3b2f71f canceled] |
|
|
||
| _, err = p.usernameProducer.Generate(dbplugin.UsernameMetadata{}) | ||
| if err != nil { | ||
| return dbplugin.InitializeResponse{}, fmt.Errorf("invalid username template - did you reference a field that isn't available? : %w", err) |
There was a problem hiding this comment.
Nit: does the error returned here tell you which field evaluated was invalid? I feel that "invalid username template: %w" might be sufficient here if so.
There was a problem hiding this comment.
Example errors:
Input: foo-{{random 5}}-{{.FooBar}}
unable to apply template: template: template:1:19: executing "template" at <.FooBar>: can't evaluate field FooBar in type dbplugin.UsernameMetadata
Input: foo-{{random 5}}-{{FooBar}}
unable to parse template: template: template:1: function "FooBar" not defined
I'll look to see if the error that's returned is structured in any meaningful way so we can make this a bit nicer to users who aren't familiar with these errors.
There was a problem hiding this comment.
Unfortunately the errors coming back from the template library (the Go one, not the one in Vault) are not structured in a useful way here. I will remove this message and put a note in the docs about common error messages.
Adds the ability to customize username generation for dynamic users in PostgreSQL.
Uses the new field
username_templatewith the go template language.Docs PR will come after all other updates for username customization are complete for this release.