Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/namespace bug #11182

Merged
merged 4 commits into from
Mar 23, 2021
Merged

UI/namespace bug #11182

merged 4 commits into from
Mar 23, 2021

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Mar 23, 2021 •
edited
Loading

Only on the binary build, if the user logged in with an empty namespace (e.g. root) they would not see the top header. Here is the error.
image
Here is the missing header
image

Note: Locally we could not reproduce, but we could on the binary build.

@Monkeychip Monkeychip added ui bug Used to indicate a potential bug labels Mar 23, 2021
@Monkeychip Monkeychip added this to the 1.7 milestone Mar 23, 2021
chelshaw
chelshaw approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@chelshaw chelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@vercel vercel bot temporarily deployed to Preview – vault March 23, 2021 20:21 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 23, 2021 20:43 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 23, 2021 20:43 Inactive
@Monkeychip Monkeychip merged commit 96bef51 into master Mar 23, 2021
@Monkeychip Monkeychip deleted the ui/namespace-bug branch March 23, 2021 20:55
Monkeychip added a commit that referenced this pull request Mar 23, 2021
@Monkeychip
UI/namespace bug (#11182)
a9f8bf0 
* fix with console to confirm showing

* remove console

* move order

* add changelog
@Monkeychip Monkeychip mentioned this pull request Mar 23, 2021
Merged
Monkeychip added a commit that referenced this pull request Mar 23, 2021
@Monkeychip
UI/namespace bug (#11182) (#11183)
51e483a 
* fix with console to confirm showing

* remove console

* move order

* add changelog
arnav28 pushed a commit that referenced this pull request May 13, 2021
@Monkeychip @arnav28
UI/namespace bug (#11182)
cb5e517 
* fix with console to confirm showing

* remove console

* move order

* add changelog
arnav28 pushed a commit that referenced this pull request May 17, 2021
@Monkeychip @arnav28
UI/namespace bug (#11182)
6a6767a 
* fix with console to confirm showing

* remove console

* move order

* add changelog
arnav28 pushed a commit that referenced this pull request May 17, 2021
@Monkeychip @arnav28
UI/namespace bug (#11182)
5c5be4b 
* fix with console to confirm showing

* remove console

* move order

* add changelog
@arnav28 arnav28 mentioned this pull request May 17, 2021
Merged
arnav28 added a commit that referenced this pull request May 17, 2021
@arnav28 @Monkeychip
UI/namespace bug (#11182) (#11633)
2f18b71 
* fix with console to confirm showing

* remove console

* move order

* add changelog

Co-authored-by: Angel Garbarino <Monkeychip@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelshaw chelshaw chelshaw approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Monkeychip @chelshaw