UI/license autoload #11778
Merged
UI/license autoload #11778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
reviewed
Jun 4, 2021
| @@ -1,22 +1,32 @@ | |||
| import { equal } from '@ember/object/computed'; | |||
| import Component from '@ember/component'; | |||
| import Component from '@glimmer/component'; | |||
Monkeychip
reviewed
Jun 4, 2021
|
|
||
| <section class="box is-sideless is-marginless is-shadowless is-fullwidth"> | ||
| <span class="title is-5">Details</span> | ||
|
|
There was a problem hiding this comment.
is it intentional leaving a line space here?
There was a problem hiding this comment.
it was just easier to parse the sections while I was working on removing code
Monkeychip
reviewed
Jun 4, 2021
ui/mirage/config.js
Outdated
| performance_standby_count: 0, | ||
| start_time: '2020-04-28T00:00:00Z', | ||
| }, | ||
| // persisted_autoload: { |
There was a problem hiding this comment.
curious why these are commented out?
There was a problem hiding this comment.
I was testing with various configurations but wanted to make sure we didn't lose the other options
Monkeychip
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update license page for autoloaded license.
When Autoloaded
Still shows standby count
Shows warning if license is stored