Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit wrapping tokens and control groups from client counts #11826

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Omit wrapping tokens and control groups from client counts #11826

merged 2 commits into from
Jun 10, 2021

Conversation

briankassouf
Copy link
Contributor

No description provided.

@briankassouf briankassouf added this to the 1.8 milestone Jun 10, 2021
swayne275
swayne275 approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@swayne275 swayne275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving because I'll be heading out for a flight soon, but i think that code suggestion i added needs to go in first. other than that, looks good!

vault/activity_log_test.go Show resolved Hide resolved
@briankassouf briankassouf merged commit e1730a1 into master Jun 10, 2021
@briankassouf briankassouf deleted the client-count-wrapping-tokens branch June 10, 2021 22:57
briankassouf added a commit that referenced this pull request Jun 10, 2021
@briankassouf
Omit wrapping tokens and control groups from client counts (#11826)
0b98580 
* Omit wrapping tokens and control groups from client counts

* add changelog note
briankassouf added a commit that referenced this pull request Jun 11, 2021
@briankassouf
Omit wrapping tokens and control groups from client counts (#11826) (#…
0a0b957 
…11827)

* Omit wrapping tokens and control groups from client counts

* add changelog note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swayne275 swayne275 swayne275 approved these changes

@sgmiller sgmiller Awaiting requested review from sgmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@briankassouf @swayne275