Allow non-strings to be used to set ttl field in generic.
#2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
May 9, 2017
| b = testPassthroughBackend() | ||
| test(b, "lease", false) | ||
| test(b, "ttl", false) | ||
| test(b, "lease", int64(10), false) |
There was a problem hiding this comment.
Should we test for passing 10 directly, as opposed to int64(10)?
There was a problem hiding this comment.
No, this ensures that the interface value is the right type. Otherwise this defaults to an int.
vishalnayak
reviewed
May 9, 2017
vault/logical_passthrough.go
Outdated
| if !ok { | ||
| ttlInt, ok = rawData["lease"] | ||
| } | ||
| if ok { |
There was a problem hiding this comment.
@jefferai Do we not want to do this regardless of ok?
There was a problem hiding this comment.
No, if ok isn't true then neither of those fields exist.
vishalnayak
approved these changes
May 9, 2017
briankassouf
reviewed
May 9, 2017
vault/logical_passthrough.go
Outdated
| ttlDuration := b.System().DefaultLeaseTTL() | ||
| if len(ttl) != 0 { | ||
| dur, err := parseutil.ParseDurationSecond(ttl) | ||
| ttlInt, ok := rawData["ttl"] |
There was a problem hiding this comment.
Small nit, but I interpreted this variable as "TTL integer" when i think it's supposed to be "TTL interface", could you rename it to ttlRaw or something similar?
briankassouf
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2697