Use the role name in the db username #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
changed the title
briankassouf
commented
Jun 5, 2017
| @@ -89,7 +96,7 @@ func PluginFactory(pluginName string, sys pluginutil.LookRunnerUtil, logger log. | |||
| // This prevents users from executing bad plugins or executing a plugin | |||
| // directory. It is a UX feature, not a security feature. | |||
| var handshakeConfig = plugin.HandshakeConfig{ | |||
| ProtocolVersion: 1, | |||
| ProtocolVersion: 2, | |||
There was a problem hiding this comment.
Bumping this means all existing plugins will need to recompile and probably update their code.
calvn
reviewed
Jun 6, 2017
| @@ -29,6 +29,13 @@ type Statements struct { | |||
| RenewStatements string `json:"renew_statements" mapstructure:"renew_statements" structs:"renew_statements"` | |||
| } | |||
|
|
|||
| // UsernameConfig is used to configure prefixes for the username to be | |||
| // generated. | |||
| type UsernameConfig struct { | |||
There was a problem hiding this comment.
What would be a case where DisplayName and RoleName are different?
There was a problem hiding this comment.
Display names are tied to tokens- the vault user who created the cred. Role name is the name of the database role that created the cred
There was a problem hiding this comment.
I see, so the role name (and unix timestamp) is now included as part of the username for more verbosity as to who and when the token was created?
jefferai
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.