Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in Expiration Manager on atomic operations #3314

Merged
merged 4 commits into from
Sep 11, 2017
Merged

Fix panic in Expiration Manager on atomic operations #3314

merged 4 commits into from
Sep 11, 2017

Conversation

chrishoffman
Copy link
Contributor

Switching atomic variables from int64 to int32 to address a Go bug that affects certain CPU architectures, specifically some ARM and x86-32 architectures.

See https://godoc.org/sync/atomic#pkg-note-bug

Fixes #3310

vishalnayak
vishalnayak approved these changes Sep 11, 2017
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrishoffman chrishoffman merged commit 10b20e5 into master Sep 11, 2017
@chrishoffman chrishoffman deleted the atomic-arm-panic branch September 11, 2017 15:17
chrishoffman pushed a commit that referenced this pull request Sep 11, 2017
Merge remote-tracking branch 'oss/master' into okta-lib-baseurl
fede390 
* oss/master:
  fix: add missing comma to payload (#3308)
  Switching atomic vars to int32 to address panic on some architectures (#3314)
chrishoffman pushed a commit that referenced this pull request Sep 14, 2017
Merge remote-tracking branch 'oss/master' into generic-to-kv
9686e5d 
* oss/master:
  Adding latency injector option to -dev mode for storage operations (#3289)
  fix: add missing comma to payload (#3308)
  Switching atomic vars to int32 to address panic on some architectures (#3314)
  Update AWS CloudHSM comparison. (#3311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrishoffman @vishalnayak