Add HTTP headers to the API client #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Oct 6, 2017
| @@ -399,6 +405,9 @@ func (c *Client) NewRequest(method, requestPath string) *Request { | |||
| if c.config.Timeout != 0 { | |||
| c.config.HttpClient.Timeout = c.config.Timeout | |||
| } | |||
| if c.headers != nil { | |||
There was a problem hiding this comment.
I think that this actually needs to iterate through and add headers, not replace the whole header structure unilaterally.
There was a problem hiding this comment.
I think this works now because the ToHTTP method that is called from RawRequest already does that if any headers in the passed in request is set: request.go. Before these changes no headers were set before ToHTTP was called.
It might be better to do as you suggested though. Let me know what you think and I'll update accordingly!
There was a problem hiding this comment.
Ah, no -- that looks fine. Thanks for clarifying!
There was a problem hiding this comment.
Great! No problem, thanks for merging this!
jefferai
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the Go API client to access Vault through a proxy with basic auth enabled. As it is now, to send the required authorization header, you have to build each request and use RawRequest to communicate with Vault.
This change makes it possible to set headers in the client that will be used for every logical-backend API call.