Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify TTL/MaxTTL logic in SSH CA paths #3507

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Simplify TTL/MaxTTL logic in SSH CA paths #3507

merged 1 commit into from
Oct 30, 2017

Conversation

jefferai
Copy link
Member

And sane with the rest of how Vault parses/returns TTLs.

cc @meirish

@jefferai jefferai added this to the 0.8.4 milestone Oct 30, 2017
vishalnayak
vishalnayak approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jefferai jefferai merged commit 3e81fe4 into master Oct 30, 2017
@jefferai jefferai deleted the sane-ssh-ttls branch October 30, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishoffman chrishoffman chrishoffman approved these changes

@vishalnayak vishalnayak vishalnayak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @chrishoffman @vishalnayak