Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/gRPC: fix issues with reserved keywords in response data #3881

Merged
merged 7 commits into from
Feb 1, 2018

Conversation

briankassouf
Copy link
Contributor

fixes #3873

vishalnayak
vishalnayak previously approved these changes Jan 31, 2018
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

calvn
calvn previously approved these changes Jan 31, 2018
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to hit approve, LGTM

@jefferai jefferai added this to the 0.9.4 milestone Feb 1, 2018
@@ -200,8 +201,14 @@ func respondRaw(w http.ResponseWriter, r *http.Request, resp *logical.Response)
retErr(w, "no status code given")
return
}
status, ok := statusRaw.(int)
if !ok {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For safety, you should add a json.Number check in here too, in case something has already serialized the data for some reason. It would be handled transparently by the JSON encoder for the response but would trip this here.

@jefferai
Copy link
Member

jefferai commented Feb 1, 2018

One comment, other than that LGTM!

@briankassouf briankassouf dismissed stale reviews from calvn and vishalnayak via ffa311c February 1, 2018 18:37
@briankassouf briankassouf merged commit 91dffed into master Feb 1, 2018
@briankassouf briankassouf deleted the fix-grpc-list branch February 1, 2018 22:30
@cypherhat
Copy link
Contributor

LGTM means Lists Good to Me? Because, list works for my plugin now! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List operations does not work in external plugins
5 participants