UI: Mount tune fix #4431
Merged
UI: Mount tune fix #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4425 |
alisdair
previously approved these changes
Apr 23, 2018
| import fields from '../form-field'; | ||
| export default { | ||
| ...fields, | ||
| ttlVaule: fillable('[data-test-ttl-value]'), |
There was a problem hiding this comment.
Lol, yep good catch.
truenorthcreative
pushed a commit
that referenced
this pull request
Apr 23, 2018
* serialize instead of toJSON when mount tuning * add tests * remove model unit test * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving the form on the mount-tune pages for auth methods, the attributes were camel-cased (defaultLeaseTtl) instead of snake-cased (default_lease_ttl) - vault still 204'd, but the fields were named incorrectly so they didn't get updated. Now we make sure to serialize the config model before tuning so that the fields are properly named.