Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure old group alias is removed when a new one is written #5350

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Ensure old group alias is removed when a new one is written #5350

merged 1 commit into from
Oct 1, 2018

Conversation

vishalnayak
Copy link
Member

@vishalnayak vishalnayak commented Sep 18, 2018 •
edited
Loading

Fixes: #5345

@vishalnayak vishalnayak added this to the 0.11.2 milestone Sep 18, 2018
@chrishoffman
Copy link
Contributor

Is there any way to deal with the entries that currently have dangling aliases? This seems to be only dealing with updated entries.

@vishalnayak
Copy link
Member Author

@chrishoffman The dangling entries are not in storage, but only in memdb, which gets refreshed by a seal/unseal cycle. With this fix in, if someone is facing this issue, they could do just that.

@briankassouf briankassouf merged commit c214e49 into master Oct 1, 2018
@briankassouf briankassouf deleted the group-alias-fix branch October 1, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishoffman chrishoffman chrishoffman approved these changes

@calvn calvn calvn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@vishalnayak @chrishoffman @calvn @briankassouf