Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked version of aliyun-oss-go-sdk #5358

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

tyrannosaurus-becks
Copy link
Contributor

Related issue: #5324
Related PR: aliyun/aliyun-oss-go-sdk#124

While we're waiting for Aliyun to merge the above PR, point at a forked version that only calls the enclosing environment when needed rather than on init.

@tyrannosaurus-becks tyrannosaurus-becks added this to the 0.11.2 milestone Sep 19, 2018
@@ -2135,6 +2129,20 @@
"revision": "b75d8614f926c077e48d85f1f8f7885b758c6225",
"revisionTime": "2015-04-27T01:28:21Z"
},
{
"checksumSHA1": "XcN5ljoQ7CTwkOW5NN9tT5ZPpPQ=",
"path": "github.com/tyrannosaurus-becks/aliyun-oss-go-sdk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one needed?

Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was hoping the upstream would be fixed in time, but let's go ahead and merge this

@briankassouf briankassouf merged commit 11abcec into master Oct 1, 2018
@briankassouf briankassouf deleted the use-forked-aliyun branch October 1, 2018 17:05
@tyrannosaurus-becks
Copy link
Contributor Author

@chrishoffman yeah, I reached out to them but they didn't respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants