Adding support for Consul 1.4 ACL system #5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passing! |
chrishoffman
changed the title
briankassouf
reviewed
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul 1.4 has different ACL system, similar the Nomad one.
Policies are de-coupled from tokens, and as such roles need to store a list of policies, as oppose to policy documents.
The policies parameter was added while maintaining the previous parameters for backwards compatibility.
At this point, tests have not been written yet as I'm waiting for a 1.4.0-rc container to be released, but most of the previous tests are passing (which is expected, it shouldn't break compatibility with old Consul installs).