Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount tune options #5809

Merged
merged 7 commits into from
Nov 19, 2018
Merged

Mount tune options #5809

merged 7 commits into from
Nov 19, 2018

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Nov 16, 2018

Following logic applies to options with this PR:

  • Keys provided will be updated
  • Keys omitted will not be changed
  • Keys provided but empty will be unset (e.g. options["foo"] = ""), with the exception of version
  • Options cannot be unset once that is set (i.e. tuning applies only when keypairs are provided as the new options map).

Closes #5788
Fixes #5237

@calvn calvn added this to the 1.0 milestone Nov 16, 2018
// Reload the backend to kick off the upgrade process.
// Reload the backend to kick off the upgrade process. It should only apply to KV backend so we
// trigger based on the version logic above.
if kvUpgraded {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briankassouf can you confirm that the comment/logic is true? If false, I can remove the kvUpgraded check and always run reloadBackendCommon whenever options gets updated.

@calvn calvn merged commit cb9998c into master Nov 19, 2018
@calvn calvn deleted the mount-tune-options branch November 19, 2018 22:23
jefferai pushed a commit that referenced this pull request Dec 14, 2018
* Refactor mount tune to support upsert options values and unset options.

* Do not allow unsetting options map

* add secret tune version regression test

* Only accept valid options version

* s/meVersion/optVersion/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants