Add operationId field to OpenAPI output #5876
Conversation
kalafut
changed the title
|
@jefferai It looks like unique within a document is by far the most common interpretation, but there have been questions to the OAS group about tightening up what the operationId uniqueness scope is. There are likely cases where you would would the exact same definitions uniquely defined. To that end I've added an optional "context" parameter (naming improvements?), that the requester can provide which will be added to the generated ID. If this approach is OK, I'll update/add tests. |
kalafut
changed the title
logical/framework/openapi.go
Outdated
| operationIDs[opID] += 1 | ||
| opID = fmt.Sprintf("%s_%d", opID, n) | ||
| } else { | ||
| operationIDs[opID] = 2 |
There was a problem hiding this comment.
Should this be 1 instead? Otherwise the above += 1 will result in 3 for the next duplicate
There was a problem hiding this comment.
It's behaves as expected (since n is used in the printf), but the code is awkward. I just pushed a change that simplifies it.
Fixes #5842