UI - kv v2 graceful degrade #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madalynrose
reviewed
Nov 30, 2018
| @@ -181,19 +181,21 @@ export default Component.extend(FocusOnInsertMixin, { | |||
| // successCallback is called in the context of the component | |||
| persistKey(successCallback) { | |||
| let secret = this.model; | |||
| let model = this.modelForData; | |||
| let secretData = this.modelForData; | |||
There was a problem hiding this comment.
omg thank you for making this less ambiguous!
madalynrose
reviewed
Nov 30, 2018
meirish
force-pushed
the
ui-kv-v2-graceful-degrade
branch
from
bc72012
to
5bcd115
Compare
meirish
changed the title
|
This only covers editing when not being able to read the metadata - you still need access to read the data before you can edit. We'll be adding write-only support for data in the near future as well as read/write for metadata when you don't have read on the data. |
|
// , I look forward to testing it, thanks for the fast response, Mr. Irish. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you need to be able to edit metadata as well as data in the kv v2 for the UI to work. This changes that so that if you don't have access to metadata, you can still edit the data.
Fixes #5840