Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator migrate use path as Entry key #6043

Closed
wants to merge 1 commit into from

Conversation

riuvshin
Copy link

@riuvshin riuvshin commented Jan 15, 2019

use path as Entry key to prevent a situation where migration results with the inconsistent state on dst

use path as Entry key to prevent a situation where migration results with the inconsistent state on dst
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 15, 2019

CLA assistant check
All committers have signed the CLA.

@kalafut kalafut self-assigned this Jan 15, 2019
@kalafut
Copy link
Contributor

kalafut commented Jan 15, 2019

This is actually seems like a Postgres storage backend bug, or at least quirk. As far as I can tell all of the other builtin storage backends populate the Key member with the requested key, not the leaf node like PG is doing. I'll dig into this a bit more.

@riuvshin
Copy link
Author

@kalafut yeah, I also thought this might be a PG issue, so I used this fix on a fork to unblock myself, and it worked. If I will have some more time I will try to investigate this from PG perspective too.

@kalafut
Copy link
Contributor

kalafut commented Jan 15, 2019

FYI: #6044

@riuvshin
Copy link
Author

@kalafut awesome! so I'm closing this in favor of #6044

@riuvshin riuvshin closed this Jan 15, 2019
@kalafut
Copy link
Contributor

kalafut commented Jan 15, 2019

Thanks for reporting the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants