Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui/http request fixes #7128

Merged
merged 3 commits into from
Jul 16, 2019
Merged

Ui/http request fixes #7128

merged 3 commits into from
Jul 16, 2019

Conversation

andaley
Copy link
Contributor

@andaley andaley commented Jul 16, 2019

This PR fixes several bugs related to the HTTP Request Metrics page:

  1. The bar chart would display duplicate ticks in some cases
  2. The bar chart wouldn't filter to specific years when you manually set the counters via the knobs panel in Storybook
  3. The select dropdown wouldn't update the selected item

Before

Screen Shot 2019-07-15 at 4 22 08 PM

After

Screen Shot 2019-07-16 at 2 12 38 PM

@andaley andaley requested a review from a team July 16, 2019 21:16
@andaley andaley added this to the 1.2 milestone Jul 16, 2019
meirish
meirish approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@meirish meirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - 👌

@andaley andaley merged commit f9268b8 into master Jul 16, 2019
@andaley andaley deleted the ui/http-request-fixes branch July 16, 2019 23:27
@andaley andaley modified the milestones: 1.2, 1.1.4 Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meirish meirish meirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@andaley @meirish