Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui search select fix #7338

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Ui search select fix #7338

merged 3 commits into from
Aug 22, 2019

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Aug 19, 2019

There was a regression where if there were no options, the error would get swallowed in a try/catch and we wouldn't show the add option.

Returning early when there are no options avoids the error.

This also updates ember-power-select-with-create to the latest release, and fixes some errors I encountered when clicking the Cancel link on the identity edit form.

@meirish meirish added ui bug Used to indicate a potential bug labels Aug 19, 2019
@meirish meirish requested a review from a team August 19, 2019 22:27
@meirish meirish added this to the 1.2.3 milestone Aug 19, 2019
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! adding the test is great and glad you got the cleanup items in there to remove .get where you could

@@ -101,7 +101,7 @@
"ember-load-initializers": "^2.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-maybe-in-element": "^0.4.0",
"ember-power-select-with-create": "cibernox/ember-power-select-with-create#6203918f247c1c5d692db4f9185ab8321d2125e1",
"ember-power-select-with-create": "^0.6.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesssssss 💅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'll be able to backport the upgrade, but the same code fixes should still work

@meirish meirish merged commit fdb788d into master Aug 22, 2019
@meirish meirish deleted the ui-search-select-fix branch August 22, 2019 18:57
meirish added a commit that referenced this pull request Aug 22, 2019
* guard against options and model not being defined

* add test for select with no options
meirish added a commit that referenced this pull request Aug 22, 2019
* guard against options and model not being defined

* add test for select with no options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants