Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.3: Only link to nav items that user has access to (#7590) #7767

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

andaley
Copy link
Contributor

@andaley andaley commented Oct 30, 2019

Backport of #7590

* only show entities sidenav item if user has list capability on entities

* wip - link to correct paths in top navigation

* remove comment

* only link to groups page if user has list capability

* add test for checking multiple capabilities

* test when capabilities are not specified

* format jsdoc comments

* move capabilities check out of helper and into permissions service
@andaley andaley added the ui label Oct 30, 2019
@andaley andaley added this to the 1.3 milestone Oct 30, 2019
@andaley andaley requested a review from a team October 30, 2019 20:17
Copy link
Contributor

@meirish meirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andaley andaley merged commit 2f4ceed into release/1.3.x Oct 30, 2019
@andaley andaley deleted the ui/backport-permissions-bug branch October 30, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants