Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TOTP MFA #812

Closed
wants to merge 2 commits into from
Closed

Added TOTP MFA #812

wants to merge 2 commits into from

Conversation

m-massaro
Copy link

Added an implementation of the OATH TOTP algorithm based on RFC 6238 and RFC 4226.
It uses SHA1 as default hashing algorithm.
The implementation is not ready to use though, we were not able to add this new method alongside the existing one (Duo MFA) and we had to replace the MFAPaths and MFARootPaths (line 28 and 35 on helper/mfa/totp/mfa.go)

@jefferai
Copy link
Member

jefferai commented Dec 3, 2015

Hi @m-massaro ,

Thanks for contributing this! We will probably need to wait on it a bit -- we are going to be revamping the backend APIs in 0.5-0.6 and along with that will probably come major changes to MFA, because we'd like to have it supportable in all backends. I'm not yet sure exactly what that will look like, but I'm marking this as "future" so that this doesn't get lost/forgotten about.

@jefferai jefferai added this to the future milestone Dec 3, 2015
@ctchurch
Copy link

ctchurch commented Aug 8, 2016

We're interested in having this functionality. What is the status of merging it in now that 0.6 is out?

@jefferai
Copy link
Member

jefferai commented Aug 8, 2016

@ctchurch We have some very big plans around this type of functionality but they're still a bit out, because we have more core work to do first. This PR in and of itself likely won't be merged; as the OP noted, it's incompatible with the existing implementation for Duo.

@sethvargo
Copy link
Contributor

Hi there,

Thank you for the PR, and sorry this sat for so long. This is available as of Vault 0.7.1: https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#071-may-5th-2017

https://www.vaultproject.io/docs/secrets/totp/index.html

@sethvargo sethvargo closed this Jun 29, 2017
@pbernal pbernal removed this from the not-scheduled milestone May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants