Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show permissions error on KV when you don't have access to create a secret #8133

Merged
merged 10 commits into from
Jan 15, 2020
Merged

Show permissions error on KV when you don't have access to create a secret #8133

merged 10 commits into from
Jan 15, 2020

Commits on Jan 10, 2020

  1. add catch for fail on save. isError is not being set to true, so set … 

    …it in the catch
    @Monkeychip
    Monkeychip committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    6d3a74a View commit details
    Browse the repository at this point in the history

  2. add conditionally to only catch 403 permission errors. Otherwise it w… 

    …ill catch and return an unhelpful error message for when you are trying to save a duplicate secret
    @Monkeychip
    Monkeychip committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    65951f4 View commit details
    Browse the repository at this point in the history

  3. add in code comment

    @Monkeychip
    Monkeychip committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    a2b3ab5 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. remove catch and pass version 2 secret model to Error handler inside … 

    …template
    @Monkeychip
    Monkeychip committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    844808c View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. replace Error model with modelForData to catch errors on the correct … 

    …model
    @Monkeychip
    Monkeychip committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    e75371e View commit details
    Browse the repository at this point in the history

  2. add back in space

    @Monkeychip
    Monkeychip committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    a4ab4b0 View commit details
    Browse the repository at this point in the history

  3. replace error model with modelForData

    @Monkeychip
    Monkeychip committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    2dbed18 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into VLTF-144-showPermissionsError-on-kv-create

    @Monkeychip
    Monkeychip authored Jan 14, 2020
    Configuration menu
    Copy the full SHA
    abe8889 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'VLTF-144-showPermissionsError-on-kv-create' of github.c… 

    …om:hashicorp/vault into VLTF-144-showPermissionsError-on-kv-create
    @Monkeychip
    Monkeychip committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    ea6781a View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Merge branch 'master' into VLTF-144-showPermissionsError-on-kv-create

    @Monkeychip
    Monkeychip authored Jan 15, 2020
    Configuration menu
    Copy the full SHA
    34ca78b View commit details
    Browse the repository at this point in the history