Backport 1.5: Disable usage metrics on performance standby nodes. (#9966) #9967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Sep 18, 2020
vault/core_metrics.go
Outdated
| if c.expiration != nil { | ||
|
|
||
| // Emit on active node only | ||
| if c.expiration != nil && !c.perfStandby { |
There was a problem hiding this comment.
Suggest c.PerfStandby() instead for locking.
There was a problem hiding this comment.
I think that some care is needed because c.stateLock can be held while acquiring c.metricsLock, so we shouldn't acquire them in the reverse order here.
ncabatoff
reviewed
Sep 18, 2020
vault/core_metrics.go
Outdated
| @@ -54,6 +57,11 @@ func (c *Core) metricsLoop(stopCh chan struct{}) { | |||
| } | |||
| c.stateLock.RUnlock() | |||
| case <-identityCountTimer: | |||
| // Only emit on active node | |||
| if c.perfStandby { | |||
ncabatoff
changed the title
ncabatoff
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.