fix missing plaintext in bulk decrypt response #9991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decrypting an ciphertext where its corresponding value equals empty, the payload property "plaintext" is missing in the response object. This fixes the problem by adding a new, distinct struct for decrypt batch response items where "omitempty" is not set.
Adding a empty string plaintext to the tests to batch decrypt test. Refactor the test assertion to check against json. This checks the correct order of the items and if the empty plaintext string is contained in the result as expected.
Adding a empty string plaintext to the tests to batch decrypt test. Refactor the test assertion to check against json. This checks the correct order of the items and if the empty plaintext string is contained in the result as expected.
|
This looks good. Can you also remove the field BatchResponseItem.Plaintext and rename BatchResponseItem to EncryptBatchResponseItem please? |
|
@ncabatoff sure thing, done :) |
ncabatoff
approved these changes
Sep 22, 2020
|
Thanks @ins0 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
plaintextproperty is correctly added for "empty" string values