-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-668 Document and Validate Properties #1001
Conversation
This reverts commit a885b8e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, despite this failure, the Github Actions report the tests are passed
1624 passing (23m)
73 pending
1 failing
1) ConfigBuilderTest
properties:
AssertionError: expected -1 to equal 'OFF'
at Context.<anonymous> (test/unit/config/ConfigBuilderTest.js:155:61)
You should probably check that out
verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from one thing, it looks good
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
=========================================
Coverage ? 92.29%
=========================================
Files ? 432
Lines ? 16717
Branches ? 1037
=========================================
Hits ? 15429
Misses ? 1019
Partials ? 269 Continue to review full report at Codecov.
|
also fixes test runner about exit status codes for gh actions to work properly
adds padded-blocks: 'never' for consistency of block newlines
fixes #894