-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.rs: Rename aarch64 compiler_builtins symbols #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
aarch64-symbols
branch
from
December 5, 2021 15:39
63d734a
to
81322df
Compare
mkroening
force-pushed
the
aarch64-symbols
branch
from
December 5, 2021 15:46
81322df
to
c19b63d
Compare
mkroening
force-pushed
the
aarch64-symbols
branch
from
December 5, 2021 15:58
e7fd5ec
to
d642c74
Compare
The duplicate symbols are from compiler-builtins.
bors try |
tryBuild succeeded: |
stlankes
approved these changes
Dec 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I forgot that we use llvm_objcopy.
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first four commits clean up the code. The last commit is the actual fix for https://github.com/hermitcore/libhermit-rs/runs/4421725682.
The duplicate symbols are from
compiler-builtins
.