Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tweet previews to CastRow component #25

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Sep 26, 2023

PR Feedback: 👎

Description

This PR adds support for tweet previews in the CastRow component of the herocast application. It introduces a new component, TweetEmbed, that uses the react-tweet package to render tweets given their IDs. The CastRow component has been modified to detect tweet URLs in the cast's embeds and render the TweetEmbed component accordingly.

Summary of Changes

  • Created a new component, TweetEmbed, in the src/common/components/Embeds directory.
  • Installed the react-tweet package using yarn.
  • Modified the CastRow component in src/common/components/CastRow.tsx to use the TweetEmbed component when a tweet URL is detected in the cast's embeds.
  • Added a new case in the renderEmbeds function to handle tweet URLs.
  • Extracted the tweet ID from the tweet URL and passed it to the TweetEmbed component for rendering.

Please review and merge this PR to add tweet previews to the CastRow component.

Fixes #24.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code will only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Sep 26, 2023
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
herocast ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 11:23am

@hellno hellno merged commit c066426 into main Sep 26, 2023
3 checks passed
@hellno hellno deleted the sweep/add-tweet-previews branch September 26, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant