Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure project publish dir #121

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Configure project publish dir #121

merged 6 commits into from
Aug 28, 2024

Conversation

runesoerensen
Copy link
Contributor

@runesoerensen runesoerensen commented Aug 28, 2024

The PublishDir MSBuild property is now set to bin/publish when running dotnet publish, to ensure that the publish output for each project is consistently sent to the same location (relative to the project file).

This enables writing Procfile commands that are compatible with any target OS/arch (i.e. Runtime Identifier (RID)), build configuration (e.g. Release/Debug) and Target Framework Moniker (TFM).

@runesoerensen runesoerensen added the enhancement New feature or request label Aug 28, 2024
@runesoerensen runesoerensen marked this pull request as ready for review August 28, 2024 13:45
@runesoerensen runesoerensen merged commit 6ee9e8b into main Aug 28, 2024
5 checks passed
@runesoerensen runesoerensen deleted the configure-publish-dir branch August 28, 2024 13:46
@heroku-linguist heroku-linguist bot mentioned this pull request Aug 29, 2024
heroku-linguist bot added a commit that referenced this pull request Aug 29, 2024
## heroku/dotnet

### Changed

- Enhanced buildpack log output to provide more detailed information on launch process detection and registration. ([#124](#124))
- Set the `PublishDir` MSBuild property to `bin/publish` when running `dotnet publish`. This change ensures that the publish output for each project is consistently placed in the same directory relative to the project file, making it easier to write `Procfile` commands that work across different OS/architectures (e.g. `linux-arm64`, `linux-x64` RIDs), build configurations (e.g. `Release`, `Debug`), and Target Framework Monikers (e.g. `net8.0`, `net6.0`). ([#121](#121))

Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant