[1429] A failed CONNACK should be sent, when a CONNECT packet exceed the max packet size #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgracchus
changed the title
DC2-DanielKrueger
force-pushed
the
bugfix/1429-connack-when-connect-exceed-packet-size/latest
branch
from
ac3eb47
to
c7eb93e
Compare
DC2-DanielKrueger
force-pushed
the
bugfix/1429-connack-when-connect-exceed-packet-size/latest
branch
from
c7eb93e
to
08e9402
Compare
DC2-DanielKrueger
approved these changes
Nov 8, 2023
DC2-DanielKrueger
force-pushed
the
bugfix/1429-connack-when-connect-exceed-packet-size/latest
branch
from
08e9402
to
ad519f1
Compare
DC2-DanielKrueger
deleted the
bugfix/1429-connack-when-connect-exceed-packet-size/latest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EXPECTED BEHAVIOR
A mqtt5 client get a negative connack with code 149; The CONNECT packet exceeded the maximum permissible size.
ACTUAL BEHAVIOR
Currently if a CONNECT packet exceeds the configured max packet size we just close the connection.
This PR fixes the issue and makes hivemq behaves as expected
Resolves
https://hivemq.kanbanize.com/ctrl_board/42/cards/17281/details/
*Changes
PR
master #170