Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(26088): Refactor frontend to align with new mapping paradigm #579

Open
wants to merge 28 commits into
base: epic/23777/bi-directional-frontend
Choose a base branch
from

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Oct 3, 2024

See https://hivemq.kanbanize.com/ctrl_board/57/cards/26088/details/

This PR is part of the bi-directional epic and aligns the codebase with the significant refactoring of the "subscription" into a "mapping" paradigm, see https://hivemq.kanbanize.com/ctrl_board/57/cards/24918/details/

Design

  • The discovery of topics has been refactored, based on the new (undocumented) structure for mappings
  • The use of "subscription" for user-facing strings in the context of adapters has been changed
  • The use of "subscription" in the codebase related to adapters has been changed

Out-of-scope

  • The "Export Mappings" functionality is designed for a single (inward) source. Extending it to bi-directionality (and fixing the design flaws) will be done in a subsequent ticket
  • The discovery of topics is still based on reverse-traversing the schema from the mqtt-topic formats, creating uncertainties when supporting bi-directional mappings. A better traversing algorithm will be implemented in a further ticket

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
@vanch3d vanch3d marked this pull request as ready for review October 3, 2024 18:14
@vanch3d vanch3d requested review from sfrehse and h2xd October 3, 2024 18:14
@vanch3d vanch3d self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant